Support for all xpack features through generic install + improved tests

tasks/xpack/elasticsearch-xpack.yml

@@ -2,6 +2,8 @@
 
 - set_fact: es_version_changed=((elasticsearch_install_from_package is defined and elasticsearch_install_from_repo.changed) or (elasticsearch_install_from_package is defined and elasticsearch_install_from_package.changed))
 
+#enabling xpack installs the license. Not a xpack feature and does not need to be specified
+
 #Check if license is installed
 - name: Check License is installed
   shell: >
@@ -26,7 +28,6 @@
     CONF_DIR: "{{ conf_dir }}"
     ES_INCLUDE: "{{ instance_default_file }}"
 
-
 #Install License if not installed, or it needs to be reinstalled due to ES change (above task will have removed), and its been requested.
 - name: Install license plugin
   command: >
@@ -40,11 +41,14 @@
     CONF_DIR: "{{ conf_dir }}"
     ES_INCLUDE: "{{ instance_default_file }}"
 
-#Include shield as we may need to remove it or change it due to es_version_changed
-- include: shield/elasticsearch-shield.yml
-#  when: '"shield" in es_xpack_features'
+#We loop on all as we may need to remove some features
+- include: elasticsearch-xpack-install.yml
+  with_items: "{{supported_xpack_features}}"
 
-#Any other xpacks plugins requiring configuration to be entered here
+#Shield configuration
+- include: shield/elasticsearch-shield.yml
+
+#Add any feature specific configuration here
 
 - name: Set Plugin Directory Permissions
   file: state=directory path={{ es_home }}/plugins owner={{ es_user }} group={{ es_group }} recurse=yes