Merge pull request #542 from grzegorznowak/check-mode-tweaks-v2

add a few more 'check_mode:no' props for compatiblity with --check

tasks/elasticsearch-config.yml

@@ -16,7 +16,6 @@
   with_items:
     - "{{data_dirs}}"
 
-
 #Copy the config template
 - name: Copy Configuration File
   become: yes
@@ -93,6 +92,7 @@
     stat:
       path: "{{ sysd_script }}"
     register: sysd_stat_result
+    check_mode: no
 
   - name: Remove if it is a normal file
     become: yes

tasks/snapshot-release.yml

@@ -27,6 +27,7 @@
   delay: 1
   ignore_errors: true
   until: "'status' in snapshots and snapshots.status == 200"
+  check_mode: no
 
 - name: use the custom package url instead of the repository
   set_fact:

tasks/xpack/security/elasticsearch-security-file.yml

@@ -6,6 +6,7 @@
   stat:
     path: '{{ conf_dir }}/x-pack/users'
   register: old_users_file
+  check_mode: no
 
 - name: Copy the old users file from the old depreacted location
   copy:
@@ -31,6 +32,7 @@
   register: current_file_users
   when: manage_file_users
   changed_when: False
+  check_mode: no
 
 - name: set fact users_to_remove
   set_fact: users_to_remove={{ current_file_users.stdout_lines | difference (es_users.file.keys()) }}

tasks/xpack/security/elasticsearch-security-native.yml

@@ -29,6 +29,7 @@
     status_code: 200
   register: user_list_response
   when: manage_native_users
+  check_mode: no
 
 - name: set fact reserved_users equals user_list_response.json
   set_fact: reserved_users={{ user_list_response.json | filter_reserved }}
@@ -138,6 +139,7 @@
     status_code: 200
   register: role_list_response
   when: manage_native_roles
+  check_mode: no
 
 - name: set fact reserved roles
   set_fact: reserved_roles={{ role_list_response.json | filter_reserved }}

tasks/xpack/security/elasticsearch-security.yml

@@ -33,6 +33,7 @@
     changed_when: False
     environment:
       ES_PATH_CONF: "{{ conf_dir }}"
+    check_mode: no
 
   - name: Create Bootstrap password for elastic user
     become: yes