Merge pull request #154 from gingerwizard/master

Fix for 147

README.md

@@ -293,3 +293,7 @@ Elasticsearch restarted where required.
 * If the ES version is changed, all plugins will be removed.  Those listed in the playbook will be re-installed.  This is behaviour is required in ES 2.x.
 * If no plugins are listed in the playbook for a node, all currently installed plugins will be removed.
 * The role does not currently support automatic detection of differences between installed and listed plugins (other than if none are listed).   Should users wish to change installed plugins should set es_plugins_reinstall to true.  This will cause all currently installed plugins to be removed and those listed to be installed.  Change detection will be implemented in future releases.
+
+## Questions on Usage
+
+We welcome questions on how to use the role.  However, in order to keep the github issues list focused on "issues" we ask the community to raise questions at https://discuss.elastic.co/c/elasticsearch.  This is monitored by the maintainers.

tasks/elasticsearch-plugins.yml

@@ -2,7 +2,8 @@
 
 # es_plugins_reinstall will be set to true if elasticsearch_install_from_repo.changed or elasticsearch_install_from_package.changed
 # i.e. we have changed ES version(or we have clean installation of ES), or if no plugins listed. Otherwise it is false and requires explicitly setting.
-- set_fact: es_plugins_reinstall={{ ((elasticsearch_install_from_package is defined and elasticsearch_install_from_repo.changed) or (elasticsearch_install_from_package is defined and elasticsearch_install_from_package.changed)) or es_plugins is not defined or es_plugins is none }}
+- set_fact: es_plugins_reinstall=true
+  when: ((elasticsearch_install_from_repo is defined and elasticsearch_install_from_repo.changed) or (elasticsearch_install_from_package is defined and elasticsearch_install_from_package.changed)) or es_plugins is not defined or es_plugins is none
 
 - set_fact: list_command="list"
 

tasks/elasticsearch-templates.yml

@@ -11,4 +11,4 @@
   copy: src={{ item }} dest=/etc/elasticsearch/templates owner={{ es_user }} group={{ es_group }}
   notify: load-templates
   with_fileglob:
-    - "{{ es_templates_fileglob | default('') }}"
+    - "{{ es_templates_fileglob | default('') }}"