remove file script feature

File scripts have been removed since elasticsearch 6.0 (https://www.elastic.co/guide/en/elasticsearch/reference/6.0/breaking_60_scripting_changes.html#_file_scripts_removed)

README.md

@@ -131,7 +131,6 @@ The following illustrates applying configuration parameters to an Elasticsearch
       node.data: false
       node.master: true
       bootstrap.memory_lock: true
-    es_scripts: false
     es_templates: false
     es_version_lock: false
     es_heap_size: 1g
@@ -171,7 +170,6 @@ A more complex example:
       node.data: false
       node.master: true
       bootstrap.memory_lock: true
-    es_scripts: false
     es_templates: false
     es_version_lock: false
     es_heap_size: 1g
@@ -212,7 +210,6 @@ An example of a two server deployment is shown below.  The first server holds th
       node.data: false
       node.master: true
       bootstrap.memory_lock: false
-    es_scripts: false
     es_templates: false
     es_version_lock: false
     ansible_user: ansible
@@ -234,7 +231,6 @@ An example of a two server deployment is shown below.  The first server holds th
       node.data: true
       node.master: false
       bootstrap.memory_lock: false
-    es_scripts: false
     es_templates: false
     es_version_lock: false
     ansible_user: ansible
@@ -256,7 +252,6 @@ An example of a two server deployment is shown below.  The first server holds th
       node.master: false
       bootstrap.memory_lock: false
       cluster.name: "test-cluster"
-    es_scripts: false
     es_templates: false
     es_version_lock: false
     es_api_port: 9201
@@ -445,9 +440,7 @@ controlled by the following parameters:
 * ```es_restart_on_change``` - defaults to true.  If false, changes will not result in Elasticsearch being restarted.
 * ```es_plugins_reinstall``` - defaults to false.  If true, all currently installed plugins will be removed from a node.  Listed plugins will then be re-installed.
 
-This role ships with sample scripts and templates located in the [files/scripts/](files/scripts) and [files/templates/](files/templates) directories, respectively. These variables are used with the Ansible [with_fileglob](http://docs.ansible.com/ansible/playbooks_loops.html#id4) loop. When setting the globs, be sure to use an absolute path.
-* ```es_scripts_fileglob``` - defaults to `<role>/files/scripts/`.
-* ```es_templates_fileglob``` - defaults to `<role>/files/templates/`.
+This role ships with sample templates located in the [files/templates/](files/templates) directory. `es_templates_fileglob` variable (defaults to `<role>/files/templates/`) is used with the Ansible [with_fileglob](http://docs.ansible.com/ansible/playbooks_loops.html#id4) loop. When setting the globs, be sure to use an absolute path.
 
 ### Proxy
 

defaults/main.yml

@@ -15,7 +15,6 @@ es_java_install: true
 update_java: false
 es_restart_on_change: true
 es_plugins_reinstall: false
-es_scripts: false
 es_templates: false
 es_user: elasticsearch
 es_group: elasticsearch

files/scripts/calculate-score.groovy

@@ -1 +0,0 @@
-log(_score * 2) + my_modifier

tasks/elasticsearch-scripts.yml

@@ -1,26 +0,0 @@
----
-
-- name: set fact es_script_dir
-  set_fact: es_script_dir={{ es_conf_dir }}/{{es_instance_name}}
-  tags:
-      - always
-
-- name: set fact es_script_dir when path.scripts
-  set_fact: es_script_dir={{es_config['path.scripts']}}
-  when: es_config['path.scripts'] is defined
-  tags:
-      - always
-
-- name: Create script dir
-  become: yes
-  file: state=directory path={{ es_script_dir }} owner={{ es_user }} group={{ es_group }} recurse=yes
-
-- name: Copy default scripts to elasticsearch
-  become: yes
-  copy: src=scripts dest={{ es_script_dir }} owner={{ es_user }} group={{ es_group }}
-  when: es_scripts_fileglob is not defined
-
-- name: Copy scripts to elasticsearch
-  become: yes
-  copy: src={{ item }} dest={{ es_script_dir }} owner={{ es_user }} group={{ es_group }}
-  with_fileglob: "{{ es_scripts_fileglob | default('') }}"

tasks/main.yml

@@ -39,12 +39,6 @@
   tags:
       - config
 
-- name: include elasticsearch-scripts.yml
-  include: elasticsearch-scripts.yml
-  when: es_scripts
-  tags:
-      - scripts
-
 - name: include elasticsearch-plugins.yml
   include: elasticsearch-plugins.yml
   when: es_plugins is defined or es_plugins_reinstall

test/integration/helpers/serverspec/multi_spec.rb

@@ -64,17 +64,6 @@ shared_examples 'multi::init' do |vars|
     end
   end
 
-  #Confirm scripts are on both nodes
-  describe file('/etc/elasticsearch/master/scripts') do
-    it { should be_directory }
-    it { should be_owned_by 'elasticsearch' }
-  end
-
-  describe file('/etc/elasticsearch/master/scripts/calculate-score.groovy') do
-    it { should be_file }
-    it { should be_owned_by 'elasticsearch' }
-  end
-
   #Confirm that the data directory has only been set for the first node
   describe file('/opt/elasticsearch/master/localhost-master') do
     it { should be_directory }

test/integration/helpers/serverspec/shared_spec.rb

@@ -90,16 +90,6 @@ shared_examples 'shared::init' do |vars|
       end
     end
   end
-  if vars['es_scripts']
-    describe file("/etc/elasticsearch/#{vars['es_instance_name']}/scripts") do
-      it { should be_directory }
-      it { should be_owned_by 'elasticsearch' }
-    end
-    describe file("/etc/elasticsearch/#{vars['es_instance_name']}/scripts/calculate-score.groovy") do
-      it { should be_file }
-      it { should be_owned_by 'elasticsearch' }
-    end
-  end
   describe file('/etc/init.d/elasticsearch') do
     it { should_not exist }
   end

test/integration/multi.yml

@@ -25,7 +25,6 @@
       bootstrap.memory_lock: true
     es_config: "{{ es_config_7x if es_major_version == '7.x' else es_config_6x }}"
     es_enable_xpack: false
-    es_scripts: true
     es_templates: true
     es_heap_size: "1g"
     es_api_port: 9200
@@ -40,7 +39,6 @@
     - elasticsearch
   vars:
     es_enable_xpack: false
-    es_scripts: true
     es_templates: true
     es_heap_size: "1g"
     es_api_port: 9201